spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] rdblue commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter
Date Wed, 25 Sep 2019 00:10:24 GMT
rdblue commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter
URL: https://github.com/apache/spark/pull/25876#issuecomment-534795394
 
 
   It looks like this changes to meaning of `ErrorIfExists` and `Ignore` to `Append`, but
that's not a safe. I understand wanting to make incremental changes, but it seems to me like
this should be combined with the addition of the catalog and identifier methods that we discussed
in the v2 sync to avoid code in master where `Ingore` actually appends data. That's a correctness
problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message