spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #25748: [SPARK-28904][K8S] Create mount for PvTestSuire
Date Tue, 24 Sep 2019 17:50:24 GMT
dongjoon-hyun commented on a change in pull request #25748: [SPARK-28904][K8S] Create mount
for PvTestSuire
URL: https://github.com/apache/spark/pull/25748#discussion_r327751274
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PVTestsSuite.scala
 ##########
 @@ -111,15 +109,28 @@ private[spark] trait PVTestsSuite { k8sSuite: KubernetesSuite =>
       .storageClasses()
       .withName(STORAGE_NAME)
       .delete()
+
+    mountProcess.foreach(_.destroy())
+
   }
 
   private def checkPVs(pod: Pod, file: String) = {
+    implicit val podName: String = pod.getMetadata.getName
+    implicit val components: KubernetesTestComponents = kubernetesTestComponents
     Eventually.eventually(TIMEOUT, INTERVAL) {
-      implicit val podName: String = pod.getMetadata.getName
-      implicit val components: KubernetesTestComponents = kubernetesTestComponents
-      val contents = Utils.executeCommand("cat", s"$CONTAINER_MOUNT_PATH/$file")
-      assert(contents.toString.trim.equals(FILE_CONTENTS))
+      Utils.executeCommand("ls", s"$CONTAINER_MOUNT_PATH/")
 
 Review comment:
   Got it~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message