spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] wangyum commented on a change in pull request #25882: [SPARK-29053][SPARK-28599][WEBUI][2.4] Sort does not work on some columns
Date Sun, 22 Sep 2019 15:56:45 GMT
wangyum commented on a change in pull request #25882: [SPARK-29053][SPARK-28599][WEBUI][2.4]
Sort does not work on some columns
URL: https://github.com/apache/spark/pull/25882#discussion_r326907950
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
 ##########
 @@ -100,7 +100,8 @@ private[ui] class ThriftServerSessionPage(parent: ThriftServerTab)
           <td>{info.groupId}</td>
           <td>{formatDate(info.startTimestamp)}</td>
           <td>{formatDate(info.finishTimestamp)}</td>
-          <td>{formatDurationOption(Some(info.totalTime))}</td>
 
 Review comment:
   https://github.com/apache/spark/pull/25855 for `ThriftServerPage`, https://github.com/apache/spark/pull/25892
for `ThriftServerSessionPage`. We can support all pages in `ThriftServerTab` after this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message