spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon opened a new pull request #25867: [SPARK-29158][SQL][FOLLOW-UP] Create an actual test case under `src/test` and minor documentation correction
Date Fri, 20 Sep 2019 10:28:05 GMT
HyukjinKwon opened a new pull request #25867: [SPARK-29158][SQL][FOLLOW-UP] Create an actual
test case under `src/test` and minor documentation correction
URL: https://github.com/apache/spark/pull/25867
 
 
   ### What changes were proposed in this pull request?
   
   This PR is a followup of https://github.com/apache/spark/pull/25838 and proposes to create
an actual test case under `src/test`. Previously, compile only test existed at `src/main`.
   
   Also, just changed the wordings in `SerializableConfiguration` just only to describe what
it does (remove other words).
   
   ### Why are the changes needed?
   
   Tests codes should better exist in `src/test` not `src/main`. Also, it should better test
a basic functionality.
   
   ### Does this PR introduce any user-facing change?
   
   No except minor doc change.
   
   ### How was this patch tested?
   
   Unit test was added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message