spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] AngersZhuuuu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable
Date Fri, 20 Sep 2019 06:36:23 GMT
AngersZhuuuu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics
of Analyzer/Optimizer use Scientific counting  human readable
URL: https://github.com/apache/spark/pull/25844#discussion_r326488795
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/QueryExecutionMetering.scala
 ##########
 @@ -85,10 +85,12 @@ case class QueryExecutionMetering() {
       s"$ruleName $runtimeValue $numRunValue"
     }.mkString("\n", "\n", "")
 
+    val totalTimeInJavaDouble =
+      (totalTime / NANOS_PER_SECOND.toDouble).asInstanceOf[java.lang.Double]
     s"""
        |=== Metrics of Analyzer/Optimizer Rules ===
        |Total number of runs: $totalNumRuns
-       |Total time: ${totalTime / NANOS_PER_SECOND.toDouble} seconds
 
 Review comment:
   > maybe we don't need 9 digits after `.`?
   
   If don't care precision, this [advice](https://github.com/apache/spark/pull/25844#discussion_r325989089)
is good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message