spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] xuanyuanking commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable
Date Fri, 20 Sep 2019 05:17:33 GMT
xuanyuanking commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional
remote maven repository in IsolatedClientLoader configurable
URL: https://github.com/apache/spark/pull/25849#discussion_r326473765
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1979,6 +1979,13 @@ object SQLConf {
       .doc("When true, the ArrayExists will follow the three-valued boolean logic.")
       .booleanConf
       .createWithDefault(true)
+
+  private[spark] val CENTRAL_REPOSITORY =
+    ConfigBuilder("spark.sql.centralRepository")
+      .doc("The default central repository used for downloading Hive jars " +
+        "in IsolatedClientLoader.")
+      .stringConf
+      .createWithDefault("https://repo1.maven.org/maven2")
 
 Review comment:
   That's right, I also test locally without setting any additional remote repo, it will pass.
   Change the default value and set the config to google mirror in 49ea1cd.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message