spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] maropu edited a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec
Date Thu, 19 Sep 2019 01:57:08 GMT
maropu edited a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array"
of javaType properly in HashAggregateExec
URL: https://github.com/apache/spark/pull/25830#issuecomment-532916337
 
 
   > Oh, this is good point. I think it is only said that aggregate function's buffer attributes
can only be in certain types. Aggregate functions still can have inputs of complex data type?
   > However I don't know if there are existing aggregate functions in Spark take complex
inputs but use buffer attributes that are acceptable for HashAggregateExec.
   > Just think in theory we might have such aggregate functions?
   
   might be so (IIUC we have no restriction about that; buffers should have the same type
with input data). So, for safeguards, how about turning off the split mode instead of forcibly
passing complex data into split functions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message