spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #25770: [SPARK-29064][CORE] Add PrometheusResource to export Executor metrics
Date Thu, 12 Sep 2019 17:26:09 GMT
dongjoon-hyun commented on a change in pull request #25770: [SPARK-29064][CORE] Add PrometheusResource
to export Executor metrics
URL: https://github.com/apache/spark/pull/25770#discussion_r323859488
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/UI.scala
 ##########
 @@ -81,6 +81,12 @@ private[spark] object UI {
     .booleanConf
     .createWithDefault(true)
 
+  val UI_PROMETHEUS_ENABLED = ConfigBuilder("spark.ui.prometheus.enabled")
 
 Review comment:
   In general, that's a better. However, here, that will introduce another dependency between
`org.apache.spark.ui` and `org.apache.spark.metrics` modules. Technically, `SparkEnv.create`
creates `MetricsSystem.createMetricsSystem` and doesn't expose it to the other modules. In
addition, `MetricsConfig` exists inside that `MetricsSystem` instance as `private[this] val
metricsConfig`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message