spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] colinmjj opened a new pull request #25759: [SPARK-19147][CORE] netty throw NPE
Date Wed, 11 Sep 2019 13:04:26 GMT
colinmjj opened a new pull request #25759: [SPARK-19147][CORE] netty throw NPE
URL: https://github.com/apache/spark/pull/25759
 
 
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline
the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your
PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will
help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   TransportClientFactory.createClient() is called by task and TransportClientFactory.close()
is called by executor.
   When stop the executor, close() will set workerGroup = null, NPE will occur in createClient
which generate many exception in log.
   For exception occurs after close(), treated it as an expected Exception
   and transform it to InterruptedException which can be processed by Executor.
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide
the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases
that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested
step by step, ideally copy and paste-able, so that other reviewers can test and check, and
descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult
to add.
   -->
   New test added in TransportClientFactorySuite

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message