spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] juliuszsompolski commented on a change in pull request #25723: [SPARK-29019][WebUI] Improve tooltip JDBC/ODBC Server tab
Date Tue, 10 Sep 2019 22:02:53 GMT
juliuszsompolski commented on a change in pull request #25723: [SPARK-29019][WebUI] Improve
tooltip JDBC/ODBC Server tab
URL: https://github.com/apache/spark/pull/25723#discussion_r322982490
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
 ##########
 @@ -72,6 +72,9 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
     val table = if (numStatement > 0) {
       val headerRow = Seq("User", "JobID", "GroupID", "Start Time", "Finish Time", "Close
Time",
         "Execution Time", "Duration", "Statement", "State", "Detail")
+      val tooltips = Seq(None, None, None, None, Some(ToolTips.THRIFT_SERVER_FINISH_TIME),
+        Some(ToolTips.THRIFT_SERVER_CLOSE_TIME), Some(ToolTips.THRIFT_SERVER_EXECUTION),
+        Some(ToolTips.THRIFT_SERVER_DURATION), None, None, None)
 
 Review comment:
   Or, if not inside `UIUtils.listingTable`, maybe add `assert(headerRow.length == tooltips.length)`
here and in ThriftServerSessionPage?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message