spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #25741: [WIP][SPARK-29032][CORE] Simplify Prometheus support by adding PrometheusServlet
Date Tue, 10 Sep 2019 15:30:21 GMT
dongjoon-hyun commented on a change in pull request #25741: [WIP][SPARK-29032][CORE] Simplify
Prometheus support by adding PrometheusServlet
URL: https://github.com/apache/spark/pull/25741#discussion_r322813610
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
 ##########
 @@ -83,13 +83,15 @@ private[spark] class MetricsSystem private (
 
   // Treat MetricsServlet as a special sink as it should be exposed to add handlers to web
ui
   private var metricsServlet: Option[MetricsServlet] = None
+  private var prometheusServlet: Option[PrometheusServlet] = None
 
   /**
    * Get any UI handlers used by this metrics system; can only be called after start().
    */
   def getServletHandlers: Array[ServletContextHandler] = {
     require(running, "Can only call getServletHandlers on a running MetricsSystem")
-    metricsServlet.map(_.getHandlers(conf)).getOrElse(Array())
+    metricsServlet.map(_.getHandlers(conf)).getOrElse(Array()) ++
 
 Review comment:
   Ur, for now, the first one is `MetricsServlet` and the other is `PrometheusServlet`. `getHandlers`
is not inherited from `Sink`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message