spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #25740: [SPARK-28412][SQL][TEST][FOLLOW-UP]Enable overlay binary function tests
Date Tue, 10 Sep 2019 08:43:32 GMT
HyukjinKwon commented on a change in pull request #25740: [SPARK-28412][SQL][TEST][FOLLOW-UP]Enable
overlay binary function tests
URL: https://github.com/apache/spark/pull/25740#discussion_r322620351
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/strings.sql
 ##########
 @@ -653,8 +653,9 @@ SELECT trim(binary('\\000') from binary('\\000Tom\\000'));
 -- SELECT btrim(E'\\000trim\\000'::bytea, ''::bytea);
 -- [SPARK-28121] decode can not accept 'escape' as charset
 -- [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array
--- SELECT encode(overlay(E'Th\\000omas'::bytea placing E'Th\\001omas'::bytea from 2),'escape');
--- SELECT encode(overlay(E'Th\\000omas'::bytea placing E'\\002\\003'::bytea from 8),'escape');
--- SELECT encode(overlay(E'Th\\000omas'::bytea placing E'\\002\\003'::bytea from 5 for 3),'escape');
 
 Review comment:
   Shall we wait for two JIRAs and enable this tests later? Once we fix the tests differently
from PostgreSQL, it will be more difficult to find and fix later each instance, and we can't
measure the feature party coverage properly and officially.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message