spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] Gschiavon commented on a change in pull request #25728: [SPARK-29020] Improving array_sort behaviour
Date Mon, 09 Sep 2019 14:47:34 GMT
Gschiavon commented on a change in pull request #25728: [SPARK-29020] Improving array_sort
behaviour
URL: https://github.com/apache/spark/pull/25728#discussion_r322233255
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ##########
 @@ -902,33 +902,45 @@ case class SortArray(base: Expression, ascendingOrder: Expression)
 
 
 /**
- * Sorts the input array in ascending order according to the natural ordering of
+ * Sorts the input array in ascending / descending order according to the natural ordering
of
  * the array elements and returns it.
  */
-// scalastyle:off line.size.limit
+// scalastyle:on line.size.limit
 
 Review comment:
   Corrected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message