spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] srowen commented on a change in pull request #25389: [SPARK-28657][CORE] Fix currentContext Instance failed sometimes
Date Fri, 06 Sep 2019 13:59:18 GMT
srowen commented on a change in pull request #25389: [SPARK-28657][CORE] Fix currentContext
Instance failed sometimes
URL: https://github.com/apache/spark/pull/25389#discussion_r321747331
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/util/Utils.scala
 ##########
 @@ -2991,7 +2991,7 @@ private[spark] class CallerContext(
     if (CallerContext.callerContextSupported) {
       try {
         val callerContext = Utils.classForName("org.apache.hadoop.ipc.CallerContext")
-        val builder = Utils.classForName("org.apache.hadoop.ipc.CallerContext$Builder")
+        val builder: Class[_] = Utils.classForName("org.apache.hadoop.ipc.CallerContext$Builder")
 
 Review comment:
   Hm OK that makes more sense. Ideally we'd use `Class.forName[CallerContext$Builder]` here,
but I presume we can't actually directly use the class. The change is fine. You could use
`Class[AnyRef]` I think to be a little more precise, but it won't matter much.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message