spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] zhengruifeng commented on a change in pull request #25671: [SPARK-28968][ML] Add HasNumFeatures in the scala side
Date Thu, 05 Sep 2019 07:31:42 GMT
zhengruifeng commented on a change in pull request #25671: [SPARK-28968][ML] Add HasNumFeatures
in the scala side
URL: https://github.com/apache/spark/pull/25671#discussion_r321112485
 
 

 ##########
 File path: python/pyspark/ml/param/shared.py
 ##########
 @@ -288,6 +288,7 @@ class HasNumFeatures(Params):
 
     def __init__(self):
         super(HasNumFeatures, self).__init__()
+        self._setDefault(numFeatures=1 << 18)
 
 Review comment:
   I am not sure, but default values of some other params (like `parallelism`/`aggregationDepth`/`distanceMeasure`)
are set in both sides

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message