spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] gaborgsomogyi commented on a change in pull request #25631: [SPARK-28928][SS] Take over Kafka delegation token protocol on sources/sinks
Date Wed, 04 Sep 2019 14:50:57 GMT
gaborgsomogyi commented on a change in pull request #25631: [SPARK-28928][SS] Take over Kafka
delegation token protocol on sources/sinks
URL: https://github.com/apache/spark/pull/25631#discussion_r320804446
 
 

 ##########
 File path: external/kafka-0-10-token-provider/src/test/scala/org/apache/spark/kafka010/KafkaConfigUpdaterSuite.scala
 ##########
 @@ -76,6 +79,25 @@ class KafkaConfigUpdaterSuite extends SparkFunSuite with KafkaDelegationTokenTes
     val params = Map(
       CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG -> bootStrapServers
     )
+    testWithTokenSetValues(params, updatedParams => {
+      assert(updatedParams.get(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG) === SASL_SSL.name)
+    })
+  }
+
+  test("setAuthenticationConfigIfNeeded with token should set values and override protocol")
{
 
 Review comment:
   See your point: `setAuthenticationConfigIfNeeded with token should prefer source protocol`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message