spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HeartSaVioR commented on issue #25673: [SPARK-28770][CORE][TEST] Fix ReplayListenerSuite tests that sometime…
Date Wed, 04 Sep 2019 08:23:21 GMT
HeartSaVioR commented on issue #25673: [SPARK-28770][CORE][TEST] Fix ReplayListenerSuite tests
that sometime…
URL: https://github.com/apache/spark/pull/25673#issuecomment-527797451
 
 
   I'd rather say we may need to find the way to let EventMonster not extending EventLoggingListener
and just buffering all events. We don't need to deal with such complicated case in EventLoggingListener,
as what we want to verify in ReplayListenerSuite is "ReplayListener can read all events sequentially
and pass to registered listeners correctly".
   
   https://github.com/apache/spark/blob/df39855db826fd4bead85a2ca01eda15c101bbbe/core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala#L236-L253
   
   I'm a bit concerned about the javadoc of EventMonster - I expect each event are posted
to be same to all listeners. If that's the understanding of us (Spark community), it would
end up with inconsistency if we allow the event itself or any fields in event to be modified
somewhere (e.g. #25672).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message