spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] kiszk commented on a change in pull request #25642: [SPARK-28916][SQL] Split subexpression elimination functions code
Date Mon, 02 Sep 2019 09:37:58 GMT
kiszk commented on a change in pull request #25642: [SPARK-28916][SQL] Split subexpression
elimination functions code
URL: https://github.com/apache/spark/pull/25642#discussion_r319882027
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ##########
 @@ -993,6 +994,14 @@ class CodegenContext {
     }
   }
 
+  /**
+   * Returns the code for subexpression elimination after splitting it if necessary.
+   */
+  def subexprFunctionsCode: String = {
+    // Wholestage codegen does not allow subexpression elimination
 
 Review comment:
   Could you elaborate on your thought on this comment?   
   IMHO, this change is not directly related to whether wholestage codegen performs subexpression
elimination by controlling in other places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message