From reviews-return-889053-archive-asf-public=cust-asf.ponee.io@spark.apache.org Mon Aug 12 15:39:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E5C7E180644 for ; Mon, 12 Aug 2019 17:39:42 +0200 (CEST) Received: (qmail 60031 invoked by uid 500); 12 Aug 2019 15:39:41 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 59921 invoked by uid 99); 12 Aug 2019 15:39:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Aug 2019 15:39:41 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] hddong commented on issue #25412: [SPARK-28691][EXAMPLES] DirectKafkaWordCount support kafka with kerberos Message-ID: <156562438151.32262.5537171648464656186.gitbox@gitbox.apache.org> Date: Mon, 12 Aug 2019 15:39:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hddong commented on issue #25412: [SPARK-28691][EXAMPLES] DirectKafkaWordCount support kafka with kerberos URL: https://github.com/apache/spark/pull/25412#issuecomment-520478013 @srowen @gaborgsomogyi ,SSL and SASL_SSL need too more parameters,such as `ssl.truststore.location` `ssl.truststore.password` `ssl.keystore.location` `ssl.keystore.password`... Is it a better choice to create another example file? cc, @dongjoon-hyun if `include something like this at all` is better , I will make some changes to support ssl authentication on this file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org