From reviews-return-881780-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Aug 1 19:53:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 35682180644 for ; Thu, 1 Aug 2019 21:53:04 +0200 (CEST) Received: (qmail 41429 invoked by uid 500); 1 Aug 2019 19:53:02 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 41371 invoked by uid 99); 1 Aug 2019 19:53:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2019 19:53:02 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] rdblue commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables Message-ID: <156468918195.712.3600394739695036803.gitbox@gitbox.apache.org> Date: Thu, 01 Aug 2019 19:53:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rdblue commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r309869532 ########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala ########## @@ -162,6 +162,16 @@ case class DataSourceResolution( case DataSourceV2Relation(CatalogTableAsV2(catalogTable), _, _) => UnresolvedCatalogRelation(catalogTable) + + // If the database name is not provided, fallback to v1 catalog. + case ShowTablesStatement(None, pattern) => + ShowTablesCommand(None, pattern) Review comment: I don't think we want catalogs to support `getCurrentDatabase`. I think the current database should be tracked by Spark and passed in. @cloud-fan is working on storing this in SessionState, I think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org