spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] zhengruifeng commented on a change in pull request #25547: [SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol
Date Thu, 22 Aug 2019 06:26:38 GMT
zhengruifeng commented on a change in pull request #25547: [SPARK-28780][ML][2.4] deprecate
LinearSVCModel.setWeightCol
URL: https://github.com/apache/spark/pull/25547#discussion_r316513289
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala
 ##########
 @@ -313,7 +313,8 @@ class LinearSVCModel private[classification] (
   setDefault(threshold, 0.0)
 
   @Since("2.2.0")
-  def setWeightCol(value: Double): this.type = set(threshold, value)
+  @deprecated("This method is deprecated and will be removed in the future.", "2.4.4")
 
 Review comment:
   I am not sure but `2.4.5` maybe anothor option?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message