spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files
Date Mon, 12 Aug 2019 12:46:14 GMT
cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core] Support rolling
back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r312905616
 
 

 ##########
 File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/TestShuffleDataContext.java
 ##########
 @@ -67,8 +67,10 @@ public void cleanup() {
   }
 
   /** Creates reducer blocks in a sort-based data format within our local dirs. */
-  public void insertSortShuffleData(int shuffleId, int mapId, byte[][] blocks) throws IOException
{
+  public void insertSortShuffleData(
+      int shuffleId, int mapId, byte[][] blocks, boolean indeterminateBlock) throws IOException
{
     String blockId = "shuffle_" + shuffleId + "_" + mapId + "_0";
+    if (indeterminateBlock) blockId += "_0";
 
 Review comment:
   `_0` is a little confusing here. Maybe we should have a `shuffleGenerationId` parameter
(by default -1), instead of 
    `indeterminateBlock`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message