spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] MaxGekk commented on a change in pull request #25408: [SPARK-28687][SQL] Support `epoch`, `isoyear`, `milliseconds` and `microseconds` at `extract()`
Date Sun, 11 Aug 2019 18:05:18 GMT
MaxGekk commented on a change in pull request #25408: [SPARK-28687][SQL] Support `epoch`, `isoyear`,
`milliseconds` and `microseconds` at `extract()`
URL: https://github.com/apache/spark/pull/25408#discussion_r312748890
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/date.sql
 ##########
 @@ -228,9 +228,9 @@ SELECT f1 - date '2000-01-01' AS `Days From 2K` FROM DATE_TBL;
 -- test extract!
 --
 -- epoch
---
--- SELECT EXTRACT(EPOCH FROM DATE        '1970-01-01');     --  0
--- SELECT EXTRACT(EPOCH FROM TIMESTAMP   '1970-01-01');     --  0
+
 
 Review comment:
   reverted to --

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message