spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] wangyum commented on a change in pull request #25366: [SPARK-27918][SQL][TEST][FOLLOW-UP] Open comment about boolean test.
Date Tue, 06 Aug 2019 08:40:40 GMT
wangyum commented on a change in pull request #25366: [SPARK-27918][SQL][TEST][FOLLOW-UP] Open
comment about boolean test.
URL: https://github.com/apache/spark/pull/25366#discussion_r310945560
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/results/pgSQL/boolean.sql.out
 ##########
 @@ -566,176 +566,332 @@ struct<tf_12_ff_4:string,f1:boolean,f1:boolean>
 
 
 -- !query 61
-CREATE TABLE BOOLTBL3 (d string, b boolean, o int) USING parquet
+SELECT '' AS True, f1
+   FROM BOOLTBL1
+   WHERE f1 IS TRUE
 -- !query 61 schema
-struct<>
+struct<True:string,f1:boolean>
 -- !query 61 output
-
+	true
+	true
+	true
 
 
 -- !query 62
-INSERT INTO BOOLTBL3 VALUES ('true', true, 1)
+SELECT '' AS "Not False", f1
 
 Review comment:
   `"Not False"` -> ``` `Not False` ```?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message