spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] rdblue commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables
Date Thu, 01 Aug 2019 19:53:01 GMT
rdblue commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES
for Data Source V2 Tables
URL: https://github.com/apache/spark/pull/25247#discussion_r309869532
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
 ##########
 @@ -162,6 +162,16 @@ case class DataSourceResolution(
 
     case DataSourceV2Relation(CatalogTableAsV2(catalogTable), _, _) =>
       UnresolvedCatalogRelation(catalogTable)
+
+    // If the database name is not provided, fallback to v1 catalog.
+    case ShowTablesStatement(None, pattern) =>
+      ShowTablesCommand(None, pattern)
 
 Review comment:
   I don't think we want catalogs to support `getCurrentDatabase`. I think the current database
should be tracked by Spark and passed in. @cloud-fan is working on storing this in SessionState,
I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message