From reviews-return-725236-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Nov 2 10:48:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EDCE618062B for ; Fri, 2 Nov 2018 10:48:49 +0100 (CET) Received: (qmail 17101 invoked by uid 500); 2 Nov 2018 09:48:49 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 17089 invoked by uid 99); 2 Nov 2018 09:48:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2018 09:48:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EF317DFE14; Fri, 2 Nov 2018 09:48:47 +0000 (UTC) From: rvesse To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo... Content-Type: text/plain Message-Id: <20181102094847.EF317DFE14@git1-us-west.apache.org> Date: Fri, 2 Nov 2018 09:48:47 +0000 (UTC) Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r230318413 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -23,6 +23,18 @@ import org.apache.spark.internal.config.ConfigBuilder private[spark] object Config extends Logging { + val KUBERNETES_CONTEXT = + ConfigBuilder("spark.kubernetes.context") + .doc("The desired context from your K8S config file used to configure the K8S " + + "client for interacting with the cluster. Useful if your config file has " + + "multiple clusters or user identities defined. The client library used " + + "locates the config file via the KUBECONFIG environment variable or by defaulting " + + "to .kube/config under your home directory. If not specified then your current " + + "context is used. You can always override specific aspects of the config file " + + "provided configuration using other Spark on K8S configuration options.") + .stringConf + .createWithDefault(null) --- End diff -- Refactored to use `Option` --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org