spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Date Sun, 04 Nov 2018 09:45:04 GMT
GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/22940

    [MINOR][R] Rename SQLUtils name to RSQLUtils in R

    ## What changes were proposed in this pull request?
    
    This PR proposes to rename `SQLUtils` name to `RSQLUtils` in R. This bugged me before
but I didn't propose to change because of backporting worry. Since we're going to 3.0.0, the
backporting concern is likely small. The name `SQLUtils` sounds quite confusing to me.
    
    This basically targets to match with Python side utils:
    
    `org.apache.spark.sql.api.python.PythonSQLUtils`
    `org.apache.spark.api.python.PythonUtils`
    
    **Before:**
    
    `org.apache.spark.sql.api.r.SQLUtils`
    `org.apache.spark.api.r.RUtils`
    
    **After:**
    
    `org.apache.spark.sql.api.r.RSQLUtils`
    `org.apache.spark.api.r.RUtils`
    
    
    ## How was this patch tested?
    
    Existing tests should cover.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark match-names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22940
    
----
commit fa4b6f91f0f0b69d54142132be1d7f07cc3dd9b9
Author: hyukjinkwon <gurwls223@...>
Date:   2018-11-04T09:37:43Z

    Match names to SQLUtils in R

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message