spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #22976: [SPARK-25974][SQL]Optimizes Generates bytecode fo...
Date Sat, 10 Nov 2018 06:06:36 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22976#discussion_r232443230
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
    @@ -133,7 +126,6 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], Ordering[InternalR
           returnType = "int",
           makeSplitFunction = { body =>
             s"""
    --- End diff --
    
    Would you update this to use `|` and `.stripMargin`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message