spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark issue #22087: [SPARK-25097][ML] Support prediction on single instance ...
Date Wed, 07 Nov 2018 15:30:08 GMT
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22087
  
    Aha. On the one hand, I suppose they can't extend that class because of the signature
difference, and indeed it says it's the superclass of regression and classification models.
I can imagine that the clustering algoritms should have a ClusteringModel superclass or something
with `predict(Vector):Int`.  That I suppose can be decided later. That is, maybe there isn't
going to be a logical overall superclass defining a universal prediction method, for reasons
like this. Yes, these things can return an Int where a Double is needed but that to me isn't
a great reason.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message