spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shahidki31 <...@git.apache.org>
Subject [GitHub] spark issue #22914: [SPARK-25900][WEBUI]When the page number is more than th...
Date Thu, 01 Nov 2018 15:19:35 GMT
Github user shahidki31 commented on the issue:

    https://github.com/apache/spark/pull/22914
  
    Hi @srowen , The current behavior of WEBUI is,
    1) When user enters a page size more than current page size, It falls back to first page
(In all the pages)
    2) When the user enters a page more than the maximum page number, page navigate to first
page but throws an exception.
    
    After the PR,
    1) Behavior is same as before
    2) Instead of throwing exception, page falls back into first page and display it contents.
    
    
    
    > Returning to the current or last page seems fine too. No error message really needed
IMHO.
    Returning to current page seems more code change is required. Because we are getting all
the parameters related to page from the url. Currently we are not passing any parameter to
get which page he was previously. 
    Also to make it consistent with the page size behaviour, we can return first page.
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message