From reviews-return-715648-archive-asf-public=cust-asf.ponee.io@spark.apache.org Sat Oct 13 23:07:35 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DF200180638 for ; Sat, 13 Oct 2018 23:07:34 +0200 (CEST) Received: (qmail 71277 invoked by uid 500); 13 Oct 2018 21:07:34 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 71266 invoked by uid 99); 13 Oct 2018 21:07:33 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Oct 2018 21:07:33 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F375FDFD77; Sat, 13 Oct 2018 21:07:32 +0000 (UTC) From: dongjoon-hyun To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org Message-ID: Subject: [GitHub] spark pull request #22716: [SPARK-25726][SQL][TEST] Fix flaky test in SaveIn... Content-Type: text/plain Date: Sat, 13 Oct 2018 21:07:32 +0000 (UTC) GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/22716 [SPARK-25726][SQL][TEST] Fix flaky test in SaveIntoDataSourceCommandSuite ## What changes were proposed in this pull request? SPARK-22479 adds a test case which sometimes fails because the used password string `123` matches `@41230802`. This PR aims to fix the flakiness. - https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97343/consoleFull ```scala SaveIntoDataSourceCommandSuite: - simpleString is redacted *** FAILED *** "SaveIntoDataSourceCommand .org.apache.spark.sql.execution.datasources.jdbc.JdbcRelationProvider@41230802, Map(password -> *********(redacted), url -> *********(redacted), driver -> mydriver), ErrorIfExists +- Range (0, 1, step=1, splits=Some(2)) " contained "123" (SaveIntoDataSourceCommandSuite.scala:42) ``` ## How was this patch tested? Pass the Jenkins with the updated test case You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/spark SPARK-25726 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22716.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22716 ---- commit 22311060aa783f5271629684e58648b8514c3bb8 Author: Dongjoon Hyun Date: 2018-10-13T21:01:30Z [SPARK-25726][SQL][TEST] Fix flaky test in SaveIntoDataSourceCommandSuite ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org