From reviews-return-723164-archive-asf-public=cust-asf.ponee.io@spark.apache.org Mon Oct 29 09:54:42 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 47CC9180627 for ; Mon, 29 Oct 2018 09:54:42 +0100 (CET) Received: (qmail 64739 invoked by uid 500); 29 Oct 2018 08:54:41 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 64728 invoked by uid 99); 29 Oct 2018 08:54:40 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Oct 2018 08:54:40 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8955FDFC9F; Mon, 29 Oct 2018 08:54:40 +0000 (UTC) From: mgaido91 To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #22830: [SPARK-25838][ML] Remove formatVersion from Savea... Content-Type: text/plain Message-Id: <20181029085440.8955FDFC9F@git1-us-west.apache.org> Date: Mon, 29 Oct 2018 08:54:40 +0000 (UTC) Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22830#discussion_r228839435 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -163,8 +163,6 @@ class LogisticRegressionModel @Since("1.3.0") ( numFeatures, numClasses, weights, intercept, threshold) } - override protected def formatVersion: String = "1.0" - --- End diff -- what do you mean by visible to users? It is protected, it is visible only if a user extends the class... --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org