From reviews-return-717615-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Oct 18 17:12:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F94418064E for ; Thu, 18 Oct 2018 17:12:50 +0200 (CEST) Received: (qmail 9537 invoked by uid 500); 18 Oct 2018 15:12:49 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 9526 invoked by uid 99); 18 Oct 2018 15:12:49 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Oct 2018 15:12:49 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 16411DFD43; Thu, 18 Oct 2018 15:12:49 +0000 (UTC) From: peter-toth To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #22766: [SPARK-25768][SQL] fix constant argument expectin... Content-Type: text/plain Message-Id: <20181018151249.16411DFD43@git1-us-west.apache.org> Date: Thu, 18 Oct 2018 15:12:49 +0000 (UTC) Github user peter-toth commented on a diff in the pull request: https://github.com/apache/spark/pull/22766#discussion_r226345858 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala --- @@ -339,40 +339,38 @@ private[hive] case class HiveUDAFFunction( val parameterInfo = new SimpleGenericUDAFParameterInfo(inputInspectors, false, false) resolver.getEvaluator(parameterInfo) } + + private case class Mode(evaluator: GenericUDAFEvaluator, objectInspector: ObjectInspector) --- End diff -- evaluator and object inspector need to be initialized together --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org