spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #22716: [SPARK-25726][SQL][TEST] Fix flaky test in SaveIn...
Date Sat, 13 Oct 2018 21:07:32 GMT
GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/22716

    [SPARK-25726][SQL][TEST] Fix flaky test in SaveIntoDataSourceCommandSuite

    ## What changes were proposed in this pull request?
    
    SPARK-22479 adds a test case which sometimes fails because the used password string `123`
matches `@41230802`. This PR aims to fix the flakiness.
    
    - https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97343/consoleFull
    
    ```scala
    SaveIntoDataSourceCommandSuite:
    - simpleString is redacted *** FAILED ***
    "SaveIntoDataSourceCommand .org.apache.spark.sql.execution.datasources.jdbc.JdbcRelationProvider@41230802,
Map(password -> *********(redacted), url -> *********(redacted), driver -> mydriver),
ErrorIfExists
    +- Range (0, 1, step=1, splits=Some(2))
    " contained "123" (SaveIntoDataSourceCommandSuite.scala:42)
    ```
    
    ## How was this patch tested?
    
    Pass the Jenkins with the updated test case

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-25726

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22716
    
----
commit 22311060aa783f5271629684e58648b8514c3bb8
Author: Dongjoon Hyun <dongjoon@...>
Date:   2018-10-13T21:01:30Z

    [SPARK-25726][SQL][TEST] Fix flaky test in SaveIntoDataSourceCommandSuite

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message