spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mallman <...@git.apache.org>
Subject [GitHub] spark pull request #22880: [SPARK-25407][SQL] Ensure we pass a compatible pr...
Date Tue, 30 Oct 2018 19:20:55 GMT
Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22880#discussion_r229450720
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
    @@ -93,13 +141,14 @@ private[parquet] class ParquetReadSupport(val convertTz: Option[TimeZone])
         log.debug(s"Preparing for read Parquet file with message type: $fileSchema")
         val parquetRequestedSchema = readContext.getRequestedSchema
     
    -    logInfo {
    -      s"""Going to read the following fields from the Parquet file:
    -         |
    -         |Parquet form:
    +    log.info {
    +      s"""Going to read the following fields from the Parquet file with the following
schema:
    +         |Parquet file schema:
    +         |$fileSchema
    +         |Parquet read schema:
    --- End diff --
    
    This detailed, formatted information was very helpful in developing and debugging this
patch. Perhaps this should be logged at the debug level instead? Even the original message
does seem rather technical for info-level logging. What do you think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message