spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark issue #22894: [SPARK-25885][Core][Minor] HighlyCompressedMapStatus des...
Date Tue, 30 Oct 2018 12:49:47 GMT
Github user mgaido91 commented on the issue:

    https://github.com/apache/spark/pull/22894
  
    @Koraseg please check the contribution guide and update this PR accordingly:
     - first, please fill the PR description properly;
     - second, provide a demonstration of the improved performance with a benchmark;
     - third, IMO this is actually worsening performances, since you are using an immutable
data structure, so the map is copied every time is modified....


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message