spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #22830: [SPARK-25838][ML] Remove formatVersion from Savea...
Date Mon, 29 Oct 2018 08:54:40 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22830#discussion_r228839435
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
    @@ -163,8 +163,6 @@ class LogisticRegressionModel @Since("1.3.0") (
           numFeatures, numClasses, weights, intercept, threshold)
       }
     
    -  override protected def formatVersion: String = "1.0"
    -
    --- End diff --
    
    what do you mean by visible to users? It is protected, it is visible only if a user extends
the class...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message