spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #22309: [SPARK-20384][SQL] Support value class in schema ...
Date Mon, 29 Oct 2018 02:35:38 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22309#discussion_r228783130
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
    @@ -184,7 +193,8 @@ object ScalaReflection extends ScalaReflection {
       private def deserializerFor(
           tpe: `Type`,
           path: Expression,
    -      walkedTypePath: Seq[String]): Expression = cleanUpReflectionObjects {
    +      walkedTypePath: Seq[String],
    +      lastType: Option[Type]): Expression = cleanUpReflectionObjects {
    --- End diff --
    
    can we add parameter doc for it?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message