spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #22809: [SPARK-19851][SQL] Add support for EVERY and ANY ...
Date Fri, 26 Oct 2018 18:56:25 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22809#discussion_r228631452
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
    @@ -282,6 +283,31 @@ trait RuntimeReplaceable extends UnaryExpression with Unevaluable
{
       override lazy val canonicalized: Expression = child.canonicalized
     }
     
    +/**
    + * An aggregate expression that gets rewritten (currently by the optimizer) into a
    + * different aggregate expression for evaluation. This is mainly used to provide compatibility
    + * with other databases. For example, we use this to support every, any/some aggregates
by rewriting
    + * them with Min and Max respectively.
    + */
    +trait UnevaluableAggregate extends DeclarativeAggregate {
    +
    +  override def nullable: Boolean = true
    --- End diff --
    
    why do we set them always as nullable?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message