spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #22771: [SPARK-25773][Core]Cancel zombie tasks in a resul...
Date Fri, 26 Oct 2018 05:35:18 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22771#discussion_r228409787
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1364,6 +1385,21 @@ private[spark] class DAGScheduler(
                       if (job.numFinished == job.numPartitions) {
                         markStageAsFinished(resultStage)
                         cleanupStateForJobAndIndependentStages(job)
    +                    try {
    +                      // killAllTaskAttempts will fail if a SchedulerBackend does not
implement
    +                      // killTask.
    +                      logInfo(s"Job ${job.jobId} is finished. Killing potential speculative
or " +
    +                        s"zombie tasks for this job")
    --- End diff --
    
    I created https://issues.apache.org/jira/browse/SPARK-25849 to improve the document.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message