spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #22512: [SPARK-25498][SQL] InterpretedMutableProjection s...
Date Tue, 23 Oct 2018 05:14:37 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22512#discussion_r227226902
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
    @@ -140,6 +141,14 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
         val input = fileToString(new File(testCase.inputFile))
     
         val (comments, code) = input.split("\n").partition(_.startsWith("--"))
    +
    +    // Runs all the tests on both codegen-only and interpreter modes. Since explain results
differ
    +    // when `WHOLESTAGE_CODEGEN_ENABLED` disabled, we don't run these tests now.
    +    val codegenConfigSets = Array(("false", "NO_CODEGEN"), ("true", "CODEGEN_ONLY")).map
{
    +      case (wholeStageCodegenEnabled, codegenFactoryMode) =>
    +        Array( // SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> wholeStageCodegenEnabled,
    --- End diff --
    
    ok


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message