spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LucaCanali <...@git.apache.org>
Subject [GitHub] spark pull request #22279: [SPARK-25277][YARN] YARN applicationMaster metric...
Date Mon, 15 Oct 2018 09:03:44 GMT
Github user LucaCanali commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22279#discussion_r225088430
  
    --- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala ---
    @@ -103,6 +103,14 @@ private[spark] class MetricsSystem private (
         sinks.foreach(_.start)
       }
     
    +  // Same as start but this method only registers sinks
    --- End diff --
    
    Thanks @attilapiros for looking at this. I agree with your proposal. I'll provide an update
to the PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message