spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #22379: [SPARK-25393][SQL] Adding new function from_csv()
Date Thu, 11 Oct 2018 23:00:47 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22379#discussion_r224629713
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVUtils.scala
---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.csv
    +
    +object CSVUtils {
    +  /**
    +   * Filter ignorable rows for CSV iterator (lines empty and starting with `comment`).
    +   * This is currently being used in CSV reading path and CSV schema inference.
    +   */
    +  def filterCommentAndEmpty(iter: Iterator[String], options: CSVOptions): Iterator[String]
= {
    +    iter.filter { line =>
    +      line.trim.nonEmpty && !line.startsWith(options.comment.toString)
    --- End diff --
    
    The same comment here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message