spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #22696: [SPARK-25708][SQL] HAVING without GROUP BY means ...
Date Thu, 11 Oct 2018 15:20:41 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22696#discussion_r224491849
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
    @@ -73,3 +73,10 @@ where b.z != b.z;
     -- SPARK-24369 multiple distinct aggregations having the same argument set
     SELECT corr(DISTINCT x, y), corr(DISTINCT y, x), count(*)
       FROM (VALUES (1, 1), (2, 2), (2, 2)) t(x, y);
    +
    +-- SPARK-25708 HAVING without GROUP BY means global aggregate
    +SELECT 1 FROM range(10) HAVING true;
    +
    +SELECT 1 FROM range(10) HAVING MAX(id) > 0;
    +
    +SELECT id FROM range(10) HAVING id > 0;
    --- End diff --
    
    before this fix, this returns 10 rows, now it fails.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message