spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szyszy <...@git.apache.org>
Subject [GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...
Date Wed, 10 Oct 2018 18:38:24 GMT
Github user szyszy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20761#discussion_r224195358
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
    @@ -288,9 +296,14 @@ private[yarn] class YarnAllocator(
           s"executorsStarting: ${numExecutorsStarting.get}")
     
         if (missing > 0) {
    -      logInfo(s"Will request $missing executor container(s), each with " +
    -        s"${resource.getVirtualCores} core(s) and " +
    -        s"${resource.getMemory} MB memory (including $memoryOverhead MB of overhead)")
    +      var requestContainerMessage = s"Will request $missing executor container(s), each
with " +
    --- End diff --
    
    Fair enough, added a condition to check whether it's enabled.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message