spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szyszy <...@git.apache.org>
Subject [GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...
Date Wed, 10 Oct 2018 02:14:19 GMT
Github user szyszy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20761#discussion_r223918024
  
    --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestTestHelper.scala
---
    @@ -0,0 +1,90 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy.yarn
    +
    +import scala.collection.JavaConverters._
    +import scala.collection.mutable.ListBuffer
    +
    +import org.apache.hadoop.yarn.api.records.Resource
    +
    +import org.apache.spark.util.Utils
    +
    +object ResourceRequestTestHelper {
    +  def initializeResourceTypes(resourceTypes: List[String]): Unit = {
    +    if (!ResourceRequestHelper.isYarnResourceTypesAvailable()) {
    +      throw new IllegalStateException("initializeResourceTypes() should not be invoked
" +
    +        "since YARN resource types is not available because of old Hadoop version!" )
    +    }
    +
    +    val allResourceTypes = new ListBuffer[AnyRef]
    +    val defaultResourceTypes = List(
    +      createResourceTypeInfo("memory-mb"),
    +      createResourceTypeInfo("vcores"))
    +    val customResourceTypes = resourceTypes.map(rt => createResourceTypeInfo(rt))
    +    allResourceTypes ++= defaultResourceTypes
    +    allResourceTypes ++= customResourceTypes
    +
    +    reinitializeResources(allResourceTypes)
    +  }
    +
    +  private def createResourceTypeInfo(resourceName: String): AnyRef = {
    +    val resTypeInfoClass = Utils.classForName("org.apache.hadoop.yarn.api.records.ResourceTypeInfo")
    +    val resTypeInfoNewInstanceMethod = resTypeInfoClass.getMethod("newInstance", classOf[String])
    +    resTypeInfoNewInstanceMethod.invoke(null, resourceName)
    +  }
    +
    +  private def reinitializeResources(resourceTypes: ListBuffer[AnyRef]): Unit = {
    --- End diff --
    
    Inlined the method


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message