spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liyinan926 <...@git.apache.org>
Subject [GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...
Date Tue, 09 Oct 2018 05:07:58 GMT
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21669#discussion_r223561204
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
    @@ -0,0 +1,182 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.features
    +
    +import io.fabric8.kubernetes.api.model.HasMetadata
    +
    +import org.apache.spark.deploy.SparkHadoopUtil
    +import org.apache.spark.deploy.k8s.{KubernetesConf, KubernetesUtils, SparkPod}
    +import org.apache.spark.deploy.k8s.Config._
    +import org.apache.spark.deploy.k8s.Constants._
    +import org.apache.spark.deploy.k8s.KubernetesDriverSpecificConf
    +import org.apache.spark.deploy.k8s.features.hadooputils._
    +import org.apache.spark.internal.Logging
    +
    + /**
    +  * Runs the necessary Hadoop-based logic based on Kerberos configs and the presence
of the
    +  * HADOOP_CONF_DIR. This runs various bootstrap methods defined in HadoopBootstrapUtil.
    +  */
    +private[spark] class KerberosConfDriverFeatureStep(
    +   kubernetesConf: KubernetesConf[KubernetesDriverSpecificConf])
    +   extends KubernetesFeatureConfigStep with Logging {
    +
    +   require(kubernetesConf.hadoopConfDir.isDefined,
    +     "Ensure that HADOOP_CONF_DIR is defined either via env or a pre-defined ConfigMap")
    +   private val hadoopConfDirSpec = kubernetesConf.hadoopConfDir.get
    +   private val conf = kubernetesConf.sparkConf
    +   private val maybePrincipal = conf.get(org.apache.spark.internal.config.PRINCIPAL)
    --- End diff --
    
    Can we avoid adding the prefix `maybe` to the variable names? They make the variables
unnecessarily longer without really improving readability much.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message