spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #22641: [SPARK-25611][SPARK-25612][SQL][TESTS] Improve te...
Date Mon, 08 Oct 2018 14:52:44 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22641#discussion_r223392700
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/CompressionCodecSuite.scala
---
    @@ -262,7 +261,10 @@ class CompressionCodecSuite extends TestHiveSingleton with ParquetTest
with Befo
         }
       }
     
    -  def checkForTableWithCompressProp(format: String, compressCodecs: List[String]): Unit
= {
    +  def checkForTableWithCompressProp(
    +     format: String,
    --- End diff --
    
    Tiny nit: I think these should be indented one more space.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message