spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...
Date Thu, 04 Oct 2018 04:12:04 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22512#discussion_r222533085
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
    @@ -238,7 +262,9 @@ object DecimalLiteral {
     /**
      * In order to do type checking, use Literal.create() instead of constructor
      */
    -case class Literal (value: Any, dataType: DataType) extends LeafExpression {
    +case class Literal(value: Any, dataType: DataType) extends LeafExpression {
    +
    +  Literal.validateLiteralValue(value, dataType)
    --- End diff --
    
    I think we should not allow it. Can you send a separated PR for this change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message