spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark pull request #22540: [SPARK-24324] [PYTHON] [FOLLOW-UP] Rename the Con...
Date Tue, 25 Sep 2018 16:57:42 GMT
Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22540#discussion_r220272980
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala
---
    @@ -131,11 +131,8 @@ object ArrowUtils {
         } else {
           Nil
         }
    -    val pandasColsByPosition = if (conf.pandasGroupedMapAssignColumnssByPosition) {
    --- End diff --
    
    It's not a big deal performance wise, but does add something. I don't think this is really
necessary because the worker has to specify a default value that matches the SQLConf anyway,
so I would leave as is but it's fine if you prefer to change it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message